Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login: Improve accessibility of Login form #78652

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Login: Improve accessibility of Login form #78652

merged 6 commits into from
Nov 28, 2023

Conversation

joshhunt
Copy link
Contributor

Fixes a few debt issues in Login form, mainly with poor a11y labels:

  1. Gives Login and Change Password input fields an ID so the label connects to the input properly. Previously, the ugly e2e selector was being used as the aria-label :(
  2. Migrates styles to emotion css objects :)

@joshhunt joshhunt added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Nov 24, 2023
@joshhunt joshhunt requested review from grafanabot and a team as code owners November 24, 2023 16:32
@joshhunt joshhunt requested review from Clarity-89 and JoaoSilvaGrafana and removed request for a team November 24, 2023 16:32
@joshhunt joshhunt added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Nov 24, 2023
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Nov 24, 2023
@joshhunt joshhunt changed the title Chore: Fix a11y debt in Login form Login: Improve accessibility of Login form Nov 24, 2023
@joshhunt joshhunt requested review from eledobleefe and removed request for JoaoSilvaGrafana November 24, 2023 16:33
ashharrison90
ashharrison90 reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits

public/app/core/components/Login/LoginLayout.tsx Outdated Show resolved Hide resolved
public/app/core/components/Login/LoginLayout.tsx Outdated Show resolved Hide resolved
ashharrison90
ashharrison90 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 just one update still missing

public/app/core/components/Login/LoginPage.tsx Outdated Show resolved Hide resolved
@joshhunt joshhunt merged commit eea35b9 into main Nov 28, 2023
19 checks passed
@joshhunt joshhunt deleted the joshhunt/login-form-a11y branch November 28, 2023 10:22
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eledobleefe eledobleefe eledobleefe left review comments

@ashharrison90 ashharrison90 ashharrison90 approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@Clarity-89 Clarity-89 Awaiting requested review from Clarity-89 Clarity-89 is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
add to changelog area/frontend no-backport Skip backport of PR
Projects
Grafana Frontend Platform
Archived in project
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joshhunt @Clarity-89 @ashharrison90 @eledobleefe @aangelisc