Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana/ui: Enable removing values in multiselect opened state #78662

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Grafana/ui: Enable removing values in multiselect opened state #78662

merged 2 commits into from
Jan 22, 2024

Conversation

FOWind
Copy link
Contributor

@FOWind FOWind commented Nov 25, 2023 •
edited
Loading

What is this feature?

  1. Enabling remove values in opened state
  2. Add storybook dev script to the package.json

Why do we need this feature?

#77698

Who is this feature for?

All users

Which issue(s) does this PR fix?:

Fixes #77698

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@FOWind FOWind requested review from a team as code owners November 25, 2023 11:34
@FOWind FOWind requested review from academo, Clarity-89 and eledobleefe and removed request for a team November 25, 2023 11:34
@CLAassistant
Copy link

CLAassistant commented Nov 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@grafana-pr-automation grafana-pr-automation bot added area/frontend pr/external This PR is from external contributor labels Nov 25, 2023
@joshhunt joshhunt added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes add to changelog and removed no-changelog Skip including change in changelog/release notes labels Nov 27, 2023
@ryantxu ryantxu changed the title GrafabaUI: enabling remove values in opened state Grafana/UI: enabling remove values in opened state Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Dec 29, 2023
@FOWind
Copy link
Contributor Author

FOWind commented Dec 29, 2023

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@joshhunt If I need to add more information about this PR?

@github-actions github-actions bot removed the stale Issue with no recent activity label Dec 30, 2023
@academo academo requested review from joshhunt and removed request for academo January 5, 2024 14:27
@Clarity-89 Clarity-89 added this to the 10.3.x milestone Jan 19, 2024
@Clarity-89 Clarity-89 changed the title Grafana/UI: enabling remove values in opened state Grafana/ui: Enable removing values in multiselect opened state Jan 19, 2024
@Clarity-89
Copy link
Contributor

@FOWind could you update this branch to the latest main?

@FOWind
Copy link
Contributor Author

FOWind commented Jan 22, 2024

@FOWind could you update this branch to the latest main?

Done

Clarity-89
Clarity-89 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Clarity-89 Clarity-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution! 🎉

@Clarity-89 Clarity-89 merged commit 1f84060 into grafana:main Jan 22, 2024
15 of 16 checks passed
@summerwollin summerwollin modified the milestones: 10.3.x, 10.3.0, 10.4.x Jan 22, 2024
@Clarity-89 Clarity-89 mentioned this pull request Jan 24, 2024
Merged
@Clarity-89
Copy link
Contributor

@FOWind unfortunately this solution doesn't work for cases where we have other elements in portals that are supposed to be top level:

Screenshot 2024-01-24 at 15 23 24

I'll revert this PR until we find a better solution for this issue.

Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@FOWind @Ukochka
Grafana/ui: Enable removing values in multiselect opened state (#78662)
04c79fa 
GrafabaUI: enabling remove values in opened state
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clarity-89 Clarity-89 Clarity-89 approved these changes

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

@joshhunt joshhunt Awaiting requested review from joshhunt

Assignees
No one assigned
Labels
add to changelog area/frontend no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Milestone
10.4.0
Development

Successfully merging this pull request may close these issues.

MultiSelect: Cannot remove values in opened state
6 participants
@FOWind @CLAassistant @Clarity-89 @joshhunt @aangelisc @summerwollin