[v10.2.x] Bug: Fix broken ui components when angular is disabled #78670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
fix(frontend): move bootstrap import to app so disabling angular doesnt break ui (cherry picked from commit 1112e90)
grafana-delivery-bot
bot
requested review from
a team and
torkelo
as code owners
grafana-delivery-bot
bot
requested review from
ashharrison90
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/frontend
backport
torkelo
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1112e90 from #78208
What is this feature?
I'm not sure if we should apply the change in this PR or wait for individual tasks to remove bootstrap usage from components. e.g #76182 I could only find this one issue so not entirely sure how widespread bootstrap usage is. 馃
This PR moves the bootstrap import from angular app to react app to resolve issues where certain components break due to missing bootstrap js when angular is disabled. We should consider this an interim solution to buy time for auditing / removing remaining bootstrap usage across the codebase without impacting users that have angular disabled in configs.
Why do we need this feature?
So angular can be disabled without causing ui issues.
Who is this feature for?
Grafana users
Which issue(s) does this PR fix?:
Fixes #76258
Special notes for your reviewer:
Please check that: