RBAC: Adjust filter for acl list to check for permissions on service accounts #78681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When we added support for service account in acl list we never adjusted the permissions filter to look for correct permissions for service accounts. Because of this a user could only list service account if they could read all users or could read a service account with a user scopes (this should not be possible).
I adjusted the filter to look for different permissions depending on if the user is marked as a service account or not.
This query is quite large and complex and I wonder if we should move out the filter from the query and check it on the service layer manually instead.
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/identity-access-team/issues/487
Special notes for your reviewer:
Please check that: