Auth: Improve groups claim setup docs for AzureAD #78791

mgyongyosi · 2023-11-29T09:33:07Z

What is this feature?
This PR extends the groups setup docs for the AzureAD provider.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

It works as expected from a user's perspective.
If this is a pre-GA feature, it is behind a feature toggle.
The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

eleijonmarck

nice update

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

chri2547

Added some suggestions, please review to ensure I didn't change the technical meaning of what you wrote. I'd like to have another review after you accept suggestions. Thank you very much for this contribution! We really appreciate it.

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

…tication/azuread/index.md Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

chri2547

Thanks for working on this. Some suggestions

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>

lwandz13

looks great!

* Improve groups claim setup docs * Improve the GroupMember.Read.All perm docs * Apply suggestions from code review * Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md * Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md * Update the groups and app roles documentation * Update * Split long list to separate sections * fix anchor * Apply suggestions from code review * Address other comments, fix anchors * Address other comments, lint * Apply suggestions from code review * Changes * final adjustments --------- Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com> Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com> (cherry picked from commit 9f93063)

Auth: Improve groups claim setup docs for AzureAD (#78791) * Improve groups claim setup docs * Improve the GroupMember.Read.All perm docs * Apply suggestions from code review * Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md * Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md * Update the groups and app roles documentation * Update * Split long list to separate sections * fix anchor * Apply suggestions from code review * Address other comments, fix anchors * Address other comments, lint * Apply suggestions from code review * Changes * final adjustments --------- Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com> Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com> (cherry picked from commit 9f93063) Co-authored-by: Misi <mgyongyosi@users.noreply.github.com>

Improve groups claim setup docs

4a8e21c

mgyongyosi added type/docs area/auth area/auth/oauth add to changelog backport v10.2.x labels Nov 29, 2023

mgyongyosi added this to the 10.3.x milestone Nov 29, 2023

mgyongyosi requested review from navbahl and MattiasSegerdahl November 29, 2023 09:33

mgyongyosi requested a review from chri2547 as a code owner November 29, 2023 09:33

Improve the GroupMember.Read.All perm docs

8b81ed4

mgyongyosi force-pushed the docs/azuread-groups branch from 585fc3f to 8b81ed4 Compare November 29, 2023 09:46

mgyongyosi requested a review from eleijonmarck November 29, 2023 10:48

eleijonmarck approved these changes Nov 29, 2023

View reviewed changes

chri2547 reviewed Nov 29, 2023

View reviewed changes

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved

chri2547 reviewed Nov 29, 2023

View reviewed changes

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved

chri2547 requested changes Nov 29, 2023

View reviewed changes

mgyongyosi and others added 4 commits November 29, 2023 16:55

Apply suggestions from code review

e113bb4

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

Update docs/sources/setup-grafana/configure-security/configure-authen…

24b970e

…tication/azuread/index.md Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

Update docs/sources/setup-grafana/configure-security/configure-authen…

6001e7d

…tication/azuread/index.md Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

Update the groups and app roles documentation

978d5e1

mgyongyosi requested a review from chri2547 November 30, 2023 15:20

mgyongyosi force-pushed the docs/azuread-groups branch from 4dffc5b to 24bf541 Compare November 30, 2023 15:21

Update

cca203a

mgyongyosi force-pushed the docs/azuread-groups branch from 24bf541 to cca203a Compare November 30, 2023 15:24

Split long list to separate sections

7d2f397

github-actions bot reviewed Dec 4, 2023

View reviewed changes

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved

mgyongyosi requested a review from lwandz13 December 4, 2023 13:09

fix anchor

93cef3e

mgyongyosi force-pushed the docs/azuread-groups branch from 9679a92 to 93cef3e Compare December 4, 2023 13:12

chri2547 reviewed Dec 4, 2023

View reviewed changes

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved

chri2547 reviewed Dec 4, 2023

View reviewed changes

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved

chri2547 requested changes Dec 4, 2023

View reviewed changes

Apply suggestions from code review

71bb0d6

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

github-actions bot reviewed Dec 5, 2023

View reviewed changes

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved

mgyongyosi added 2 commits December 5, 2023 10:11

Address other comments, fix anchors

65949dc

Address other comments, lint

3970b5d

mgyongyosi requested a review from chri2547 December 5, 2023 11:41

IevaVasiljeva approved these changes Dec 5, 2023

View reviewed changes

lwandz13 reviewed Dec 5, 2023

View reviewed changes

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved

lwandz13 requested changes Dec 5, 2023

View reviewed changes

mgyongyosi and others added 2 commits December 6, 2023 12:19

Apply suggestions from code review

1121dff

Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>

Changes

d2de37c

mgyongyosi requested a review from lwandz13 December 6, 2023 12:19

final adjustments

22fb59b

chri2547 approved these changes Dec 6, 2023

View reviewed changes

lwandz13 approved these changes Dec 7, 2023

View reviewed changes

mgyongyosi merged commit 9f93063 into main Dec 7, 2023
12 checks passed

mgyongyosi deleted the docs/azuread-groups branch December 7, 2023 14:31

grafana-delivery-bot bot mentioned this pull request Dec 7, 2023

[v10.2.x] Auth: Improve groups claim setup docs for AzureAD #79227

Merged

3 tasks

aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auth: Improve groups claim setup docs for AzureAD #78791

Auth: Improve groups claim setup docs for AzureAD #78791

mgyongyosi commented Nov 29, 2023 •

edited

eleijonmarck left a comment

chri2547 left a comment

chri2547 left a comment

lwandz13 left a comment

Auth: Improve groups claim setup docs for AzureAD #78791

Auth: Improve groups claim setup docs for AzureAD #78791

Conversation

mgyongyosi commented Nov 29, 2023 • edited

eleijonmarck left a comment

Choose a reason for hiding this comment

chri2547 left a comment

Choose a reason for hiding this comment

chri2547 left a comment

Choose a reason for hiding this comment

lwandz13 left a comment

Choose a reason for hiding this comment

mgyongyosi commented Nov 29, 2023 •

edited