Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo: Fix read-only access error #78801

Merged
merged 3 commits into from Dec 1, 2023

Conversation

fabrizio-grafana
Copy link
Contributor

@fabrizio-grafana fabrizio-grafana commented Nov 29, 2023

In some environment, trying to update newQueries[i].query causes the following error in some environments:

TypeError: Cannot assign to read only property 'query' of object '#<Object>'

This PR changes the code to directly create updated TraceToMetricQuery objects instead of changing the query property later.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Nov 29, 2023
@fabrizio-grafana fabrizio-grafana self-assigned this Nov 29, 2023
@fabrizio-grafana fabrizio-grafana marked this pull request as ready for review November 29, 2023 10:49
@fabrizio-grafana fabrizio-grafana requested a review from a team as a code owner November 29, 2023 10:49
@fabrizio-grafana fabrizio-grafana requested review from tskarhed, JoaoSilvaGrafana and a team and removed request for a team November 29, 2023 10:49
Copy link
Contributor

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestions, but I think this looks good 👍

We should probably also update the link label in the same way. Does not have to be in the PR if you'd like to create another one.

…gs.tsx

Co-authored-by: Joey <90795735+joey-grafana@users.noreply.github.com>
@fabrizio-grafana fabrizio-grafana merged commit ae3f150 into main Dec 1, 2023
15 checks passed
@fabrizio-grafana fabrizio-grafana deleted the otp/fix-read-only-access-error branch December 1, 2023 12:55
@fabrizio-grafana fabrizio-grafana modified the milestones: 10.3.x, 10.2.x Dec 1, 2023
@aangelisc aangelisc modified the milestones: 10.2.x, 10.2.3 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants