[v10.1.x] Chore: Fix timeout issues when gathering prometheus datasource stats #78858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
grafana-delivery-bot
bot
requested review from
zserge,
mildwonkey and
nikimanoledaki
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/backend
backport
DanCech
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3c89e68 from #74618
The code that gathers stats about the flavors of prometheus in use can often cause timeouts when target servers are not available or respond very slowly. This PR updates the collector to process datasources in parallel and to use a shorter 5s timeout for the HTTP requests to avoid blocking stats collection.