DeleteDashboard: Redirect to home after deleting a dashboard

[ivanortegaalba]

Fixes #78810

Diagnosis
The useDeleteDashboard was listening to when the result was present in the state.value from useAsyncFn giving a cb to be called onDeleteDashboard. The callback returned by useAsyncFn is used inside another useAsyncFn that hides the modal once the onDeleteDashboard is resolved.

Because onDeleteDashboard is resolved before the next re-render is triggered, the useEffect declared in useDeleteDashboard is never called, so the variables and the replace is never invoked.

Solution
I just simplified this piece of code, since the custom hook useDeleteDashboard is never used. I approached moving everything into a single async callback called when the user clicks confirm. I also removed the duplicated notification to show only one since it did not add much value.

[evictorero]

I've tested it and works as expected. Left some comments.

[ivanortegaalba]

I've tested it and works as expected. Left some comments.

Fixed, sorry

[evictorero]

LGTM! Shouldn't be backported since it is a regression?

[dprokop]

Works as expected, nice!

Did you manage to figure out when/what introduced this regression? Also, I think this may deserve a backport to 10.2.x

[ivanortegaalba]

Sorry, I got confused with the backport policy vs unscheduled releases. Marked as backport.

@dprokop, it was caused because the hiddenModal function was hiding the modal before the modal re-renders since it is upper in the shadow dom hierarchy. So the hook was not triggering the callbacks under if (state.value).

When this changes, I don't know. The code from our side hasn't been modified in 2 years. My only guess is they fixed something in the execution order of the useAsyncFn.