[v10.2.x] DeleteDashboard: Redirect to home after deleting a dashboard #78936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8d7314b from #78918
Fixes #78810
Diagnosis
The
useDeleteDashboard
was listening to when the result was present in thestate.value
fromuseAsyncFn
giving a cb to be calledonDeleteDashboard
. The callback returned byuseAsyncFn
is used inside anotheruseAsyncFn
that hides the modal once theonDeleteDashboard
is resolved.Because
onDeleteDashboard
is resolved before the next re-render is triggered, the useEffect declared inuseDeleteDashboard
is never called, so the variables and the replace is never invoked.Solution
I just simplified this piece of code, since the custom hook
useDeleteDashboard
is never used. I approached moving everything into a single async callback called when the user clicks confirm. I also removed the duplicated notification to show only one since it did not add much value.