Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.2.x] Auth: Add anonymous users view and stats #78965

Merged
merged 2 commits into from Dec 4, 2023

Conversation

Jguer
Copy link
Contributor

@Jguer Jguer commented Dec 1, 2023

Backport 59bdff0 from #78685


What is this feature?

  • anonymous users users page
  • add feature toggle displayAnonymousStats
  • remove check for enterprise for X-Grafana-Device-Id header in request
  • add anonusers/device count to stats

Why do we need this feature?
We want to surface the anonymous users to our users as well as show a count of them in the stats page.

Special notes for your reviewer:
image
image

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

* Add anonymous stats and user table

- anonymous users users page
- add feature toggle `anonymousAccess`
- remove check for enterprise for `Device-Id` header in request
- add anonusers/device count to stats

* promise all, review comments

* make use of promise all settled

* refactoring: devices instead of users

* review comments, moved countdevices to httpserver

* fakeAnonService for tests and generate openapi spec

* do not commit openapi3 and api-merged

* add openapi

* Apply suggestions from code review

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* formatin

* precise anon devices to avoid confusion

---------

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
Co-authored-by: jguer <me@jguer.space>
(cherry picked from commit 59bdff0)
@Jguer Jguer added type/docs area/backend area/frontend add to changelog backport A backport PR product-approved Pull requests that are approved by product/managers and are allowed to be backported labels Dec 1, 2023
@Jguer Jguer added this to the 10.2.x milestone Dec 1, 2023
@Jguer Jguer self-assigned this Dec 1, 2023
@Jguer Jguer requested review from grafanabot and a team as code owners December 1, 2023 16:25
@Jguer Jguer requested review from mgyongyosi, danielkenlee, mildwonkey, suntala, yangkb09, Clarity-89 and JoaoSilvaGrafana and removed request for a team December 1, 2023 16:25
@Jguer Jguer merged commit b548b8e into v10.2.x Dec 4, 2023
12 checks passed
@Jguer Jguer deleted the backport-78685-to-v10.2.x branch December 4, 2023 14:48
@aangelisc aangelisc modified the milestones: 10.2.x, 10.2.3 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend area/frontend backport A backport PR product-approved Pull requests that are approved by product/managers and are allowed to be backported type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants