Transformations: Move transformation help to drawer component #79247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeincarnate
requested review from
oscarkilhed,
mdvictor,
Clarity-89 and
eledobleefe
and removed request for
a team
oscarkilhed
approved these changes
Dec 12, 2023
|
I think the name of the transformation should be emphasized here, maybe even skip the "Transformation help" header. @catherineymgui wdyt? |
|
I think having the header about what this modal is providing is helpful. But yeah we could flip the hierarchy and size for "Transformation help" and the name of the transformation Also I noticed in the help - the "Note:" section has a different font size than the rest of the body |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
github-actions
bot
added
stale
codeincarnate
requested review from
Develer and
drew08t
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team and
jackw
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Move help to drawer component * Update component name * Flip hierarchy of transformation name and help description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
We've been moving a number of transformation components into a
Drawerto make better use of screen space. Along the same lines we moved help into aModalrecently as well. This builds on that by moving help into aDraweras well to make it consistent with other controls.Under the surface it also renames
TransformationEditorHelperModaltoTransformationEditorHelpDisplay.Why do we need this feature?
This provides transformation help while still allowing visualization/transformations to still be visible. This also brings this behavior inline with the rest of the behavior of transformations which are currently using the Drawer component.
Who is this feature for?
Users of transformations
Please check that: