Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Fix UI inheriting mute timings from parent when calculating the polic… #79295

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

soniaAguilarPeiron
Copy link
Member

What is this feature?

The UI incorrectly assumes that mute timings are inherited from the parent in the notification policy tree. The current behavior in Prometheus is that routes do not inherit mute timings, despite existing issues related to this in the Prometheus GitHub repository. This discrepancy arises due to unclear documentation on this specific case.

From Prometheus documentation:

A route block defines a node in a routing tree and its children. Its optional configuration parameters are inherited from its parent node if not set.

However, the reality is that mute timings are not applied in this inheritance.

⚠️ I think we should be alert to potential changes in this behavior considering that there are several open issues regarding this matter.

This PR fixes this wrong inheritance in the UI.

Why do we need this feature?

UI should be consistent with the Prometheus current behaviour.

Who is this feature for?

All users.

Special notes for your reviewer:

Before:

Screenshot 2023-12-11 at 09 19 30

After:

Screenshot 2023-12-11 at 09 19 41

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added this to the 10.3.x milestone Dec 11, 2023
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this Dec 11, 2023
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner December 11, 2023 08:40
@soniaAguilarPeiron soniaAguilarPeiron requested review from gillesdemey, VikaCep and konrad147 and removed request for a team December 11, 2023 08:40
@soniaAguilarPeiron soniaAguilarPeiron force-pushed the alerting-fix-inheriting-mute-timmings branch from 56e2f3b to f562681 Compare December 11, 2023 09:03
@soniaAguilarPeiron soniaAguilarPeiron added type/bug and removed backport A backport PR labels Dec 11, 2023
Copy link
Contributor

@VikaCep VikaCep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!!

@soniaAguilarPeiron soniaAguilarPeiron merged commit fdb4626 into main Dec 11, 2023
20 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the alerting-fix-inheriting-mute-timmings branch December 11, 2023 14:49
@summerwollin summerwollin modified the milestones: 10.3.x, 10.3.0 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants