New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Can add static headers to email messages #79365
Config: Can add static headers to email messages #79365
Conversation
…c headers get added to emails.
@hairyhenderson Tested this locally with the smtprelay logging and it works as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking great! I'll defer to the codeowners of the SMTP service for final approval, but this seems good to me. I had just a couple minor nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working on this @owensmallwood 🥳
fixes https://github.com/grafana/hosted-grafana/issues/5058
You can add static headers config in the
smtp.static_headers
section for headers to get added to emails.Example grafana config could be:
Example
Add the following to your grafana config:
Edit: The header validation was updated to only work with smtp headers before I recorded this 👇
Then send an email and inspect the headers: