Alerting: Add export mute timings feature to the UI. #79395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey,
VikaCep and
konrad147
and removed request for
a team
soniaAguilarPeiron
force-pushed
the
alerting/export-mutetimings
branch
from
3bba472
to
d8a8a97
Compare
soniaAguilarPeiron
force-pushed
the
alerting/export-mutetimings
branch
from
d8a8a97
to
0b6a95f
Compare
VikaCep
reviewed
Dec 12, 2023
public/app/features/alerting/unified/components/export/GrafanaMuteTimingsExporter.tsx
Outdated
Show resolved
Hide resolved
VikaCep
approved these changes
Dec 12, 2023
| exportMuteTimings: build.query<string, { format: ExportFormats }>({ | ||
| query: ({ format }) => ({ | ||
| url: `/api/v1/provisioning/mute-timings/export/`, | ||
| params: { format: format }, |
There was a problem hiding this comment.
Suggested change
| params: { format: format }, | |
| params: { format }, |
| exportMuteTiming: build.query<string, { format: ExportFormats; muteTiming: string }>({ | ||
| query: ({ format, muteTiming }) => ({ | ||
| url: `/api/v1/provisioning/mute-timings/${muteTiming}/export/`, | ||
| params: { format: format }, |
There was a problem hiding this comment.
Suggested change
| params: { format: format }, | |
| params: { format }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds export for all mute timings and for a single mute timing.
Why do we need this feature?
After the new export endpoints for exporting mute timings where added to the provisioning api, we want to provide same functionality to the ui.
Who is this feature for?
All users.
Special notes for your reviewer:
export-mute-timings.mp4
Please check that: