OAuth: Remove accessTokenExpirationCheck feature toggle #79455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyongyosi
added
type/docs
area/auth
area/auth/oauth
add to changelog
no-backport
lwandz13
previously requested changes
Dec 13, 2023
docs/sources/setup-grafana/configure-security/configure-authentication/gitlab/index.md
Outdated
Show resolved
Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/gitlab/index.md
Outdated
Show resolved
Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/google/index.md
Outdated
Show resolved
Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/keycloak/index.md
Outdated
Show resolved
Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/okta/index.md
Outdated
Show resolved
Hide resolved
mgyongyosi
requested review from
grafanabot,
a team and
chri2547
as code owners
Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>
Jguer
approved these changes
Dec 14, 2023
chri2547
approved these changes
Dec 14, 2023
kalleep
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
The code part looks good to me.
One suggestion would to cache the check here https://github.com/grafana/grafana/blob/main/pkg/services/authn/authnimpl/sync/oauth_token_sync.go#L66. So we are not doing additonal database call for every request but that can be done in a followup pr
mgyongyosi
dismissed
lwandz13’s stale review
lwandz13 is OOO and Chris (from the docs team) has already approved it
…token-exp-check-ft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR removes the
accessTokenExpirationCheckfeature toggle completely. The access token expiration check + refresh token fetching can be enabled in the OAuth provider settings using the previously introduced (v10.2)use_refresh_tokenconfig.Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: