React Hook Form: Update to v 7.49.2 #79493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
requested review from
kaydelaney and
joshhunt
and removed request for
a team
Clarity-89
requested review from
ashharrison90 and
JoaoSilvaGrafana
and removed request for
joshhunt
gillesdemey
requested changes
Dec 20, 2023
gillesdemey
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Addressed the Alerting-related concern in f24bf2f – LGTM from our side
juanicabanas
approved these changes
Dec 21, 2023
public/app/features/alerting/unified/components/mute-timings/MuteTimingTimeRange.tsx
Show resolved
Hide resolved
ashharrison90
approved these changes
Jan 2, 2024
Elfo404
approved these changes
Jan 3, 2024
|
/deploy-to-hg |
|
|
grafana-pr-automation
bot
requested review from
a team and
academo
and removed request for
a team
zserge
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Update RHF to latest * Update Form types * Fix alerting types * Fix correlations types * Update tests * Fix tests * Update LabelsField.tsx to use InputControl * Update RuleEditorGrafanaRules.test.tsx * Update RuleEditorCloudRules.test.tsx * Only require one label * Update RuleEditorRecordingRule.test.tsx * Fix labels rules * Revert * Remove RHF from ignore rules * Revert * update form validation for overriding group timings * Fix changes to correlations * Fix auth type errors --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Kristina Durivage <kristina.durivage@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Update the react-hook-form package to the latest version.
Why do we need this feature?
The version of RHF we have is a few years old. Updating to the new version has a few benefits:
Special notes for your reviewer:
I see that RHF is included in the renovate ignore list to avoid breaking the Form component API. I think we'd just deprecate the Form component from grafana/ui, which would remove the extra non ui-related dependency we need to maintain.