Alerting: Fix queries and expressions in rule view details. #79497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
type/bug
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey,
VikaCep and
konrad147
and removed request for
a team
soniaAguilarPeiron
changed the title
soniaAguilarPeiron
changed the title
VikaCep
approved these changes
Dec 14, 2023
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
* fix queries and expressions in rule-view details * Add test (cherry picked from commit 6fffbe4)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR fixes queries and expressions not being shown in alert view page.
The bug was introduced in this PR, where Stack component from
@grafana/experimentalin favor of@grafana/ui.The recent update to the Stack component in
@grafana/uidefaults to usingnowrap. Consequently, some Stacks in our current view were automatically switched to nowrap, leading to the observed issue.Special notes for your reviewer:
Before the change: (observe there is no D query)
before-queries-in-rule-view.mp4
After the change:
after-fix-queries-in-rule-view.mp4
Please check that: