Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Disable add new data source for incomplete install #79658

Merged
merged 3 commits into from Dec 19, 2023
Merged

Plugins: Disable add new data source for incomplete install #79658

merged 3 commits into from Dec 19, 2023

Conversation

oshirohugo
Copy link
Contributor

@oshirohugo oshirohugo commented Dec 18, 2023 •
edited

What is this feature?

Disable "Add new data source" button when plugin installation isn't completed and show tooltip

Why do we need this feature?

This would prevent wrong grafana behavior for incomplete plugin installation.

Who is this feature for?

Catalog users

Special notes for your reviewer:

disabled-button

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@oshirohugo oshirohugo self-assigned this Dec 18, 2023
@oshirohugo oshirohugo requested a review from a team as a code owner December 18, 2023 16:51
@oshirohugo oshirohugo requested review from academo and removed request for a team December 18, 2023 16:51
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Dec 18, 2023
academo
academo reviewed Dec 19, 2023
View reviewed changes
public/app/features/plugins/admin/components/GetStartedWithPlugin/GetStartedWithDataSource.tsx Outdated
<Button
variant="primary"
onClick={onAddDataSource}
disabled={
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a tooltip explaining to the user why they can't add a new datasource?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR description with the tooltip screenshot. Let me know your thoughts

academo
academo approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oshirohugo oshirohugo merged commit ecfc804 into main Dec 19, 2023
16 checks passed
@oshirohugo oshirohugo deleted the disable-add-new-data-source-button-for-uncompleted-install branch December 19, 2023 13:53
@summerwollin summerwollin modified the milestones: 10.3.x, 10.3.0 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@academo academo academo approved these changes

Assignees

@oshirohugo oshirohugo

Labels
add to changelog area/frontend no-backport Skip backport of PR
Projects
Plugins Platform
Archived in project
Milestone
10.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oshirohugo @academo @summerwollin