Loki Logs volume: Added a query splitting loading indicator to the Logs Volume graph #79681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the original implementation of query splitting we wanted to display a loading indicator for the paritioned log volume query, but time pressure and some bugs led to postpone it.
In a recent user interview we noticed how confusing it can be to see partial data in the logs volume graph, without a clue to wether it finished loading or not. Hence, we're adding support to the loading frame.
Why do we need this feature?
Feature completion of query splitting.
Less paper cuts, less confusion, more transparency to users.
Who is this feature for?
Loki users.
Which issue(s) does this PR fix?:
Fixes #77645
Special notes for your reviewer:
Please check that: