Loki: Drop all errors in volume requests #79686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svennergr
added
datasource/Loki
add to changelog
no-backport
svennergr
commented
Dec 19, 2023
| @@ -219,6 +219,11 @@ export class LokiDatasource | |||
| return undefined; | |||
| } | |||
|
|
|||
| const dropErrorExpression = `${expr} | drop __error__`; | |||
| if (isQueryWithError(this.interpolateString(dropErrorExpression, placeHolderScopedVars)) === false) { | |||
There was a problem hiding this comment.
Just a small safeguard that we're not breaking any query with that. Not really sure when and how that could happen though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds a
drop __error__operation to all Loki log volume queries. By this we can also display the "histogram" in case the underlying logs are not well formatted.Special notes for your reviewer:
On Loki devenv with the change:
On Loki devenv without the change:
