Alerting: Allow linking to library panels #79693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
requested review from
konrad147 and
soniaAguilarPeiron
and removed request for
a team
public/app/features/alerting/unified/components/notification-policies/Policy.tsx
Outdated
Show resolved
Hide resolved
soniaAguilarPeiron
approved these changes
Dec 19, 2023
…y-panels-selection
|
CI seems to fail for unrelated reason :( EDIT: I've merged #79705 on CI and it should be green after rebase |
…y-panels-selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR will allow selecting a "library panel" to link the alert to.
Prior to this PR we were checking for a valid panel
typebut this doesn't seem to be returned via the/api/dashboards/uid/:uidAPI endpoint we use.grafana/public/app/features/alerting/unified/components/rule-editor/DashboardPicker.tsx
Line 280 in 2a25320
This PR loosens the restriction to allow selecting any library panel as it might be a graph or time series type. The UI will still display a warning that only those types are supported but won't stop the user from selecting it.
Special notes for your reviewer:
I've added a simple regression test to check if all panels in the picker are enabled.