Alerting: Fix reusing last url in tab when reopening a new tab in rule detail a…

[soniaAguilarPeiron]

What is this feature?

This PR fixes some buttons reusing the last url in the tab recently opened instead of opening the url assigned to these hrefs
In particular this happened when accessing the alerting list page on an instance and clicking:

• See Graph
• Go to dashboard
• Go to panel
• Silence

The problem was we were using __blank instead of _blank , so the new tab was reusing this existing __blank named tab instead of opening a new one (as _blank option does).

Who is this feature for?

All users.

Special notes for your reviewer:

Before the fix:

before-fix-tab-reoopening-last-one.mp4

After the fix:

after-fix-tab-reoopening-last-one.mp4

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[soniaAguilarPeiron]

/deploy-to-hg

[ephemeral-instances-bot]

• Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
• Your instance will be ready in ~10 minutes.
• Check the GitHub actions tab to follow the workflow progress
• Slack channel: #proj-ephemeral-hg-instances
• Building instance with alerting/fix-opening-last-tab oss branch and main enterprise branch. How to choose a branch

[ephemeral-instances-bot]

• Your instance can be accessed at: https://ephemeral1511182179801soniaag.grafana-dev.net
• The instance is not using the CDN assets.
• How to access / How to update instance config / How to build a specific branch

[gillesdemey]

I'm pretty sure that's not supposed to be the default behaviour of a browser; there might be something else at play here? Can we dig a bit deeper to find out why it's just re-opening that last tab instead of opening a new tab with the target URL?

[soniaAguilarPeiron]

I'm pretty sure that's not supposed to be the default behaviour of a browser; there might be something else at play here? Can we dig a bit deeper to find out why it's just re-opening that last tab instead of opening a new tab with the target URL?

you're right! even these changes fixed the problem, I found the real cause of opening the same tab anytime...
In the code we have __blank instead of _blank !!

[gillesdemey]

Good catch!