Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Hide forgot password if grafana auth is disabled #79895

Merged
merged 2 commits into from Jan 4, 2024

Conversation

Jguer
Copy link
Contributor

@Jguer Jguer commented Dec 28, 2023

What is this feature?

Fixes #76046

Hide Forgot Password if Grafana Login is disabled

[auth]
disable_login = true

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Jguer Jguer added add to changelog no-backport Skip backport of PR labels Dec 28, 2023
@Jguer Jguer self-assigned this Dec 28, 2023
@Jguer Jguer requested review from a team as code owners December 28, 2023 17:35
@Jguer Jguer requested review from tskarhed, L-M-K-B, sunker, mildwonkey, idafurjes and yangkb09 and removed request for a team December 28, 2023 17:35
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Dec 28, 2023
@Jguer Jguer changed the title Auth:hide forgot password if grafana auth is disabled Auth: Hide forgot password if grafana auth is disabled Dec 28, 2023
@Jguer Jguer requested review from a team January 3, 2024 13:51
>
Forgot your password?
</LinkButton>
{!config.auth.disableLogin && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could parameterize disableLogin instead of using config.auth.disablelogin

@Jguer Jguer merged commit 5ae3249 into main Jan 4, 2024
18 checks passed
@Jguer Jguer deleted the jguer/hide-forgot-password-if-no-grafana-auth branch January 4, 2024 09:46
@summerwollin summerwollin modified the milestones: 10.3.x, 10.3.0 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login form: forgot password link not hidden when using LDAP
3 participants