Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barchart: Fix percent stacking regression #79903

Merged
merged 7 commits into from Jan 5, 2024
Merged

Conversation

nmarrs
Copy link
Contributor

@nmarrs nmarrs commented Dec 29, 2023

Missed a slight regression when merging in #78511

Fixes regression by re-adding specific legend option to barchart and only applying unit modification to data provided to legend specifically.

Checking related gdev dashboards and it seems all is right now :)
Bar Chart Tooltips & Legends
TimeSeries & BarChart Stacking

Screen.Recording.2023-12-28.at.5.18.58.PM.mov

Fixes #79731

@nmarrs nmarrs added this to the 10.3.x milestone Dec 29, 2023
@nmarrs nmarrs self-assigned this Dec 29, 2023
@nmarrs nmarrs requested a review from a team as a code owner December 29, 2023 00:27
@nmarrs nmarrs requested review from leeoniya and drew08t and removed request for a team December 29, 2023 00:27
Copy link
Contributor

@leeoniya leeoniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmarrs nmarrs enabled auto-merge (squash) January 5, 2024 16:46
@nmarrs nmarrs merged commit 3609dbd into main Jan 5, 2024
13 checks passed
@nmarrs nmarrs deleted the barchart-percent-regression branch January 5, 2024 16:58
zserge pushed a commit that referenced this pull request Jan 22, 2024
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
@summerwollin summerwollin modified the milestones: 10.3.x, 10.3.0 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BarChart: Percent stacking regression with unit rendering on axis and values
3 participants