Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryEditor: Display error even if error field is empty #79943

Merged
merged 3 commits into from Jan 3, 2024

Conversation

idastambuk
Copy link
Contributor

What is this feature?
I noticed that errors aren't displayed in the panel when we pass only errors field from Cloudwatch. We'd have to pass error field as well, even though it's deprecated. This adds the support for only errors but keeps it compatible with error.

Screenshot 2024-01-02 at 17 39 47

[Add a brief description of what the feature or update does.]

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@idastambuk idastambuk requested a review from a team as a code owner January 2, 2024 16:46
@idastambuk idastambuk requested review from axelavargas and kaydelaney and removed request for a team January 2, 2024 16:46
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.3.x milestone Jan 2, 2024
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@idastambuk idastambuk changed the title QueryEditorRow: Display error even if error field is empty QueryEdito: Display error even if error field is empty Jan 3, 2024
@idastambuk idastambuk changed the title QueryEdito: Display error even if error field is empty QueryEditor: Display error even if error field is empty Jan 3, 2024
@idastambuk idastambuk merged commit a255058 into main Jan 3, 2024
29 checks passed
@idastambuk idastambuk deleted the queryeditorrow/errors branch January 3, 2024 10:32
@summerwollin summerwollin modified the milestones: 10.3.x, 10.3.0 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants