Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Switch component not being styled as disabled when is checked #80012

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Fix: Switch component not being styled as disabled when is checked #80012

merged 4 commits into from
Jan 4, 2024

Conversation

soniaAguilarPeiron
Copy link
Member

@soniaAguilarPeiron soniaAguilarPeiron commented Jan 4, 2024 •
edited
Loading

What is this feature?

This PR fixes Switch component not having any visual indication that the Switch is checked when is also disabled.

Special notes for your reviewer:

Before the change:

Screenshot 2024-01-04 at 13 09 44

After the change:
Screenshot 2024-01-04 at 13 04 44

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added this to the 10.3.x milestone Jan 4, 2024
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this Jan 4, 2024
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner January 4, 2024 09:38
@soniaAguilarPeiron soniaAguilarPeiron requested review from joshhunt and L-M-K-B and removed request for a team January 4, 2024 09:38
@soniaAguilarPeiron soniaAguilarPeiron added no-changelog Skip including change in changelog/release notes add to changelog type/bug and removed add to changelog labels Jan 4, 2024
@soniaAguilarPeiron soniaAguilarPeiron changed the title Fix Switch component not being styled as disabled when checked Grafana-UI: Fix Switch component not being styled as disabled when checked Jan 4, 2024
@soniaAguilarPeiron soniaAguilarPeiron changed the title Grafana-UI: Fix Switch component not being styled as disabled when checked Grafana-UI: Fix Switch component not being styled as disabled Jan 4, 2024
@soniaAguilarPeiron soniaAguilarPeiron changed the title Grafana-UI: Fix Switch component not being styled as disabled Fix: Switch component not being styled as disabled when is checked Jan 4, 2024
JoaoSilvaGrafana
JoaoSilvaGrafana approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this!

@soniaAguilarPeiron soniaAguilarPeiron merged commit d29f9cf into main Jan 4, 2024
17 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the fix-switch-disabled-and-checked branch January 4, 2024 14:07
zserge pushed a commit that referenced this pull request Jan 22, 2024
@soniaAguilarPeiron @zserge
Fix: Switch component not being styled as disabled when is checked (#…
49a0bce 
…80012)

* Fix Switch component not being styled as disabled when checked

* Remove unnecessary code
@summerwollin summerwollin modified the milestones: 10.3.x, 10.3.0 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoSilvaGrafana JoaoSilvaGrafana JoaoSilvaGrafana approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@soniaAguilarPeiron soniaAguilarPeiron

Labels
add to changelog area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
10.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soniaAguilarPeiron @JoaoSilvaGrafana @summerwollin