Loki: Fix metric time splitting to split starting with the start time #80085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svennergr
added
type/bug
datasource/Loki
add to changelog
no-backport
svennergr
requested review from
axelavargas and
ivanortegaalba
and removed request for
a team
matyax
approved these changes
Jan 8, 2024
| // to include the 08.02.2022, which we don't want. So we have to start from | ||
| // the start, always ending at the last step before the actual end, or the total end. | ||
| for (let chunkStartTime = alignedStartTime; chunkStartTime < endTime; chunkStartTime += alignedDuration) { | ||
| const chunkEndTime = Math.min(chunkStartTime + alignedDuration - step, endTime); |
zserge
pushed a commit
that referenced
this pull request
Jan 22, 2024
…#80085) * Loki: Fix metric time splitting to split starting with the start time * add test case to gdev-dashboard * fix splitting test
s0lesurviv0r
pushed a commit
to s0lesurviv0r/grafana
that referenced
this pull request
Feb 3, 2024
…grafana#80085) * Loki: Fix metric time splitting to split starting with the start time * add test case to gdev-dashboard * fix splitting test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
With Grafana's query splitting in Loki we previously expanded the timerange in such a way, that it might lead to querying more data than needed. E.g. a query with a
1dstep and1drange over any specific duration would always lead to include an additional day.This PR fixes the adjustment of the end time range, and the calculation of metric splits. With this change, the smallest split will always be near the
endtime, i.e. it will also be the part that will be queried first. However, only with this we can ensure that we are not going out of bounds of the given duration.Special notes for your reviewer:
I added two panels to the query splitting gdev dashboard that should showcase the issue:
Without the change:
With the change:
