Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelContext: Remove deprecated onSplitOpen #80087

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

harisrozajac
Copy link
Contributor

@harisrozajac harisrozajac commented Jan 5, 2024

What is this feature?

Removes deprecated PanelContext.onSplitOpen, which can be removed in 10.4

Fixes #72596

Release notice breaking change

PanelContext.onSplitOpen is removed. In the context of Explore, plugins should use field.getLinks to get a list of data link models.

@harisrozajac harisrozajac added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Jan 5, 2024
@harisrozajac harisrozajac added this to the 10.4.x milestone Jan 5, 2024
@harisrozajac harisrozajac self-assigned this Jan 5, 2024
@harisrozajac harisrozajac requested a review from a team as a code owner January 5, 2024 15:27
@harisrozajac harisrozajac requested review from tskarhed and ashharrison90 and removed request for a team January 5, 2024 15:27
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 10.4.x, 10.3.x Jan 5, 2024
@grafana-pr-automation
Copy link

grafana-pr-automation bot commented Jan 5, 2024

⚠️   Possible breaking changes (md version)*  &nbsp ⚠️

grafana-ui

Removals

PanelContext.onSplitOpen
/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts
onSplitOpen?: SplitOpen;


Read our guideline
Console output

@grafana-pr-automation grafana-pr-automation bot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Jan 5, 2024
@grafana-pr-automation grafana-pr-automation bot requested review from a team and jackw and removed request for a team January 5, 2024 15:31
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm 👍 but i'm not sure they've cut the build for 10.3.0 yet so we might have to wait for that first before merging

Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also just thought this probably needs a breaking change and add to changelog label, as well as a breaking change notice (see e.g. #77569 for an example)

@gelicia gelicia modified the milestones: 10.3.x, 10.4.x Jan 8, 2024
@grafana-pr-automation grafana-pr-automation bot requested a review from a team January 17, 2024 19:52
@harisrozajac harisrozajac added add to changelog breaking change Relevant for changelog generation and removed no-changelog Skip including change in changelog/release notes levitate breaking change A label indicating a breaking change and assigned by Levitate. labels Jan 22, 2024
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🙌

@harisrozajac harisrozajac merged commit e4a0a6a into main Jan 23, 2024
30 of 31 checks passed
@harisrozajac harisrozajac deleted the haris/remove-deprecated-onsplitopen branch January 23, 2024 14:13
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend breaking change Relevant for changelog generation no-backport Skip backport of PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Explore: Remove deprecated PanelContext.onSplitOpen
4 participants