-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PanelContext: Remove deprecated onSplitOpen #80087
Conversation
grafana-uiRemovalsPanelContext.onSplitOpen/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts onSplitOpen?: SplitOpen; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm 👍 but i'm not sure they've cut the build for 10.3.0 yet so we might have to wait for that first before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also just thought this probably needs a breaking change
and add to changelog
label, as well as a breaking change notice (see e.g. #77569 for an example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🙌
Remove deprecated onSplitOpen
What is this feature?
Removes deprecated PanelContext.onSplitOpen, which can be removed in
10.4
Fixes #72596
Release notice breaking change
PanelContext.onSplitOpen
is removed. In the context of Explore, plugins should usefield.getLinks
to get a list of data link models.