Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Context: Add highlighted words to log rows #80119

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

svennergr
Copy link
Contributor

What is this feature?

Log context did not highlight searchwords in other than the "center" log line. This PR adds searchWords also to the "above" and "before" log lines in Log Context.

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment suggestion below, but overal looks good!

…odal.tsx

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
@svennergr svennergr enabled auto-merge (squash) January 9, 2024 10:45
@svennergr svennergr merged commit 0f8d4db into main Jan 9, 2024
14 checks passed
@svennergr svennergr deleted the svennergr/log-context-searchwords branch January 9, 2024 10:56
@ifrost ifrost modified the milestones: 10.3.x, 10.4.x Jan 12, 2024
zserge pushed a commit that referenced this pull request Jan 22, 2024
* Log Context: Add highlighted words to log rows

* Update public/app/features/logs/components/log-context/LogRowContextModal.tsx

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

---------

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
s0lesurviv0r pushed a commit to s0lesurviv0r/grafana that referenced this pull request Feb 3, 2024
* Log Context: Add highlighted words to log rows

* Update public/app/features/logs/components/log-context/LogRowContextModal.tsx

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

---------

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants