NestedFolders: Support Shared with me folder for showing items you've been granted access to #80141

joshhunt · 2024-01-08T12:36:29Z

Updates the Browse Dashboards UI with special presentation for the Shared with me pseudo-folder.

Use users-alt icon
Don't link to folder page
Render a divider after all sharedwithme children
- Adds a new 'divider' UI tree item
- Switch to VariableSizeList from react-window so the divider UI tree item can be rendered with a height of 0

Part of #78752

public/app/features/browse-dashboards/components/DashboardsTree.tsx

ashharrison90

couple of questions:

what happens when there's nothing in shared with me? does the section just not display at all?
looks like you're able to move/delete items in the shared with me section. what happens if you move an item in shared with me to one of your normal folders, does it disappear from shared with me and just appear in the normal part of the dashboard list?

joshhunt · 2024-01-08T13:10:07Z

@ashharrison90

what happens when there's nothing in shared with me? does the section just not display at all?

From my observation, Shared with me does not display for admins (as they always will have access to everything?). For other users, it will always display even if it's empty.

looks like you're able to move/delete items in the shared with me section.

I think this is valid, at least as valid as it is everywhere else. The user may have permission to move or delete items in Shared with me, so we must display the options. The overall problem (not specific to shared with me) is that we don't get ACLs on children when listing, so we can't accurately show checkboxes in the list.

what happens if you move an item in shared with me to one of your normal folders, does it disappear from shared with me and just appear in the normal part of the dashboard list?

Yes - Shared with me only lists items that you don't have permission on it's immediate parent. If you move an item out of Shared with Me and into another folder that you have permission on, it'll no longer appear in Shared with Me.

ephemeral-instances-bot · 2024-01-09T16:51:44Z

Your instance can be accessed at: https://ephemeral1511182180141joshhun.grafana-dev.net
The instance is not using the CDN assets.
How to access / How to update instance config / How to build a specific branch

ashharrison90

code lgtm, nice job 🥳

gonna tentatively approve, but there's some commented out code to remove and i just wanna redeploy the ephemeral instance and make sure nothing's borked itself in the refactors 😂

ashharrison90 · 2024-01-12T17:26:42Z

public/app/features/search/service/utils.ts

+  }
+}
+
+// export function getIconForItem(itemOrKind: string | DashboardViewItemWithUIItems, isOpen?: boolean): IconName {


commented out code can go 💀

joshhunt · 2024-01-12T17:28:28Z

/deploy-to-hg

ephemeral-instances-bot · 2024-01-12T17:29:12Z

Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
Your instance will be ready in ~10 minutes.
Check the GitHub actions tab to follow the workflow progress
Slack channel: #proj-ephemeral-hg-instances
Building instance with joshhunt/shared-with-me-frontend oss branch and main enterprise branch. How to choose a branch

ephemeral-instances-bot · 2024-01-12T17:38:30Z

Your instance can be accessed at: https://ephemeral1511182180141joshhun.grafana-dev.net
The instance is not using the CDN assets.
How to access / How to update instance config / How to build a specific branch

git push

… been granted access to (grafana#80141) * start shared with me frontend tweaks * prevent linking to sharedwithme folder * tests * make divider take up 0 height * Prevent sharedwithme from being selected * test git push * pr feedback * prevent setting url for sharedwithme * split iconForItem/kind functions * Hide sharedwithme in nested folder picker * fix test fixture

joshhunt requested a review from a team as a code owner January 8, 2024 12:36

joshhunt requested review from ashharrison90 and eledobleefe and removed request for a team January 8, 2024 12:36