Runtime: Add property for disabling caching #80245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aangelisc
requested review from
tskarhed,
L-M-K-B and
mckn
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
adamyeats
approved these changes
Jan 10, 2024
mmandrus
approved these changes
Jan 11, 2024
|
@aangelisc @mckn it's not necessary to introduce a new properly, since there's existing property
Cache should be disabled regardless whether it's Azure user authentication or "Forward OAuth Identity":
|
|
@kostrse pasting my response here for brevity: I'd rather have a distinct property which is why the new one has been added, data sources may decide to disable caching even when they have |
s0lesurviv0r
pushed a commit
to s0lesurviv0r/grafana
that referenced
this pull request
Feb 3, 2024
* Add property for disabling caching * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of implementing user-based authentication, it is necessary to disable caching for security reasons. Caching should be disabled at a data source level based on the configuration of the data source.
In order to support this, an additional property has been added to the data source JSON data that will indicate to the caching service whether or not a data source instance supports caching.
Part of grafana/grafana-enterprise-mirror-shared-microsoft#170
Fixes #85634