Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geomap: Support geojson styling properties #80272

Merged
merged 15 commits into from Jan 20, 2024

Conversation

drew08t
Copy link
Contributor

@drew08t drew08t commented Jan 10, 2024

Add support for embedding polygon styles (fill, fill-opacity, stroke-width) within geojson feature properties. Based on community contribution.

Based on this geojson styling spec which conforms to geojson spec, specifically for feature properties.

A geojson with embedded styles has been included as an example.

image

Closes #76083, #80491, #80274

@drew08t drew08t changed the title [WIP] Geomap: Support geojson styling properties Geomap: Support geojson styling properties Jan 12, 2024
@drew08t drew08t marked this pull request as ready for review January 12, 2024 01:11
@drew08t drew08t requested review from ryantxu and a team as code owners January 12, 2024 01:11
@drew08t drew08t requested review from nmarrs and removed request for a team January 12, 2024 01:11
Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some formatting suggestions

Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and this is looking good!

@nmarrs
Copy link
Contributor

nmarrs commented Jan 13, 2024

The options seem to be off based on the current color 🤔 not sure what is going on there

Screenshot 2024-01-12 at 8 34 09 PM

Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally and looks good! I'm a bit concerned by the comparisons but beyond that seems fine 😄

@drew08t
Copy link
Contributor Author

drew08t commented Jan 16, 2024

The options seem to be off based on the current color 🤔 not sure what is going on there

Screenshot 2024-01-12 at 8 34 09 PM

Hmm, that example definitely shouldn't look like that. Are you still experiencing this after panel refresh?

@nmarrs
Copy link
Contributor

nmarrs commented Jan 20, 2024

Internal note: add this to misc viz improvements for 10.4

@drew08t drew08t enabled auto-merge (squash) January 20, 2024 00:52
@drew08t drew08t merged commit 378c863 into main Jan 20, 2024
15 checks passed
@drew08t drew08t deleted the drew08t/geomap-geojson-styling-polygons branch January 20, 2024 00:55
@drew08t drew08t mentioned this pull request Jan 22, 2024
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
* Geomap: Support geojson styling properties

* Add enum for geojson styles

* Move styleStrings outside of style function

* Add styling note to geoJSON docs

* Clean up geomap docs

* Add support for points

* Add simple example

* Add support for all geojson types and update example

* Update colors

* Update docs

* Remove old TODO

* Update geojson name

---------

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geomap: geojson styling
7 participants