Logs: Add show context to dashboard panel #80403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svennergr
added
area/panel/logs
no-backport
svennergr
requested review from
joshhunt,
ashharrison90 and
jackw
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team and
sunker
and removed request for
a team
gtk-grafana
reviewed
Jan 12, 2024
| {showCommonLabels && !isAscending && renderCommonLabels()} | ||
| <LogRows | ||
| logRows={logRows} | ||
| // always return true for now as this propery will |
There was a problem hiding this comment.
Is there more to this comment?
There was a problem hiding this comment.
Lol, removed that. Good catch!
gtk-grafana
approved these changes
Jan 12, 2024
grafana-pr-automation
bot
requested review from
a team and
sunker
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team and
mckn
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
svennergr
added
add to changelog
and removed
no-changelog
s0lesurviv0r
pushed a commit
to s0lesurviv0r/grafana
that referenced
this pull request
Feb 3, 2024
* Logs: Add show context to dashboard panel * add prop to enable show context toggle * update test * adjust tests * add query targets as a dependency * extract `useDatasourcesFromTargets` hook * add tests * remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds the "Log Context" functionality to the LogsPanel, i.e. it enables this feature for logs panels in dashboards.
Special notes for your reviewer: