Alerting: Fix firing alerts title when showing active in Insights panel #80414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
type/bug
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey and
konrad147
and removed request for
a team
soniaAguilarPeiron
force-pushed
the
alerting/fix-alerts-firing-count-in-insights
branch
from
bcea985
to
2d2cd98
Compare
soniaAguilarPeiron
changed the title
…iring-count-in-insights
|
/deploy-to-hg |
|
|
gillesdemey
approved these changes
Jan 12, 2024
soniaAguilarPeiron
deleted the
alerting/fix-alerts-firing-count-in-insights
branch
s0lesurviv0r
pushed a commit
to s0lesurviv0r/grafana
that referenced
this pull request
Feb 3, 2024
…el (grafana#80414) * Fix firing alerts title when showing active alerts in Insights panel * Update red to green and change the component name to Active.tsx instead of Firing.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR fixes Insights panel title for showing firing alerts count.
So far, this panel was counting alerts with 'active' state when an active rule is not always firing, so the number is incorrect.
After reviewing the rest of the panels, we realised that actually there is another panel showing the firing count. So, we think that the problem here is not the count but the title, as there is no other panel showing active alerts.
Who is this feature for?
All cloud users.
Which issue(s) does this PR fix?:
Fixes #80348
Please check that: