Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Add metric counting rule groups per org #80669

Merged
merged 2 commits into from Jan 16, 2024

Conversation

alexweav
Copy link
Contributor

What is this feature?

Adds a metric, grafana_alerting_rule_groups, which tracks rule groups.
The current metrics emitted by the scheduler only track rules.

This will also inform the cardinality impact of adding rule_group as a label, like how Prometheus works.

Why do we need this feature?
n/a

Who is this feature for?
operators, anyone observing Grafana

Which issue(s) does this PR fix?:

n/a

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@alexweav alexweav requested a review from a team as a code owner January 16, 2024 19:18
@alexweav alexweav requested review from rwwiv, JacobsonMT, yuri-tceretian and grobinson-grafana and removed request for a team January 16, 2024 19:18
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Jan 16, 2024
@alexweav alexweav modified the milestone: 10.4.x Jan 16, 2024
@alexweav alexweav merged commit 3c796ec into main Jan 16, 2024
23 checks passed
@alexweav alexweav deleted the alexweav/groups-metrics branch January 16, 2024 22:35
s0lesurviv0r pushed a commit to s0lesurviv0r/grafana that referenced this pull request Feb 3, 2024
* Refactor, fix bad map hint

* Count groups per org
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
* Refactor, fix bad map hint

* Count groups per org
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants