Pyroscope: Fix stale value for query in query editor #80753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joey-grafana
added
type/bug
area/frontend
add to changelog
area/datasource/frontend
no-backport
aocenas
reviewed
Jan 18, 2024
public/app/plugins/datasource/grafana-pyroscope-datasource/QueryEditor/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/grafana-pyroscope-datasource/QueryEditor/QueryEditor.tsx
Show resolved
Hide resolved
aocenas
reviewed
Jan 18, 2024
public/app/plugins/datasource/grafana-pyroscope-datasource/QueryEditor/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Fix stale value for query in query editor * Separate out onLabelSelectorChange into its own hook * Move queryRef inside hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Fixes issue with stale query value in Pyroscope query editor.
Why do we need this feature?
We need to reference the query as otherwise when it's passed into useLabels, only the initial value of the query is passed into the LabelsEditor (onChange) which renders the CodeEditor for Monaco. The above needs to have a ref to the query so it can get the latest value.
Who is this feature for?
Tempo users/
Which issue(s) does this PR fix?:
Fixes #80502
Fixes #80765
Special notes for your reviewer:
Please check that: