Logs Panel: Permalink (copy shortlink) #80764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es/61434/total-logs-logs-volume
…s, gave up on building dashboard url which was breaking view/edit functionality, now just using existing url and setting new parameters
gtk-grafana
commented
Jan 18, 2024
gtk-grafana
commented
Jan 18, 2024
gtk-grafana
commented
Jan 18, 2024
gtk-grafana
commented
Jan 18, 2024
matyax
reviewed
Jan 23, 2024
matyax
reviewed
Jan 23, 2024
matyax
reviewed
Jan 23, 2024
|
Just leaving this here without testing: we should make sure that added functionality will not directly show up for apps or scenes plugins without making sure it's working for them as well. That's why we decided to disable LogContext for apps by default, and enable it for dashboards. |
matyax
reviewed
Jan 23, 2024
Co-authored-by: Matias Chomicki <matyax@gmail.com>
gtk-grafana
changed the title
…n logs panels used in scenes/apps
|
Good catch @svennergr, that would have broken the logs app. How could we catch this automatically instead of relying on someone remembering? |
Hm, good call. Let's move that question to our next standup to discuss 👍 |
gtk-grafana
changed the title
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
Compute permalink url for log lines within logs panels in dashboards. --------- Co-authored-by: Matias Chomicki <matyax@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adding the short-links that currently exist in explore, to the dashboard panel!
Why do we need this feature?
Parity between explore/logs panels, sharing individual logs within the context of a dashboard can be valuable for
teams debugging with logs.
Who is this feature for?
Users of logs panels in dashboards.
Special notes for your reviewer:
Please check that: