Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations: Focus search input on drawer open #80859

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

codeincarnate
Copy link
Collaborator

What is this feature?

When adding transformations there is a search box which can be used to filter transformations. Currently this isn't focused when the drawer is opened causing an extra click. While auto-focusing on fields is generally not considered the best for accessibility when the drawer is open this field in the only text field which can be interacted with. In this case that seems like a reasonable trade-off.

Why do we need this feature?

It streamlines the addition of new transformations.

Who is this feature for?

Users of transformations.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@codeincarnate codeincarnate requested a review from a team as a code owner January 19, 2024 08:05
@codeincarnate codeincarnate requested review from leeoniya and adela-almasan and removed request for a team January 19, 2024 08:05
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Jan 19, 2024
@codeincarnate codeincarnate added the no-backport Skip backport of PR label Jan 19, 2024
@codeincarnate codeincarnate merged commit 6484f4a into main Jan 24, 2024
14 checks passed
@codeincarnate codeincarnate deleted the codeincarnate/transform-drawer-focus branch January 24, 2024 04:19
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
* Focus search input on drawer open

* Prettier
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants