Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BarChart: TooltipPlugin2 #80920

Merged
merged 20 commits into from
Feb 27, 2024
Merged

BarChart: TooltipPlugin2 #80920

merged 20 commits into from
Feb 27, 2024

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Jan 19, 2024 •
edited by adela-almasan
Loading

barchart_tooltip.mov

@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Jan 19, 2024
@grafana-pr-automation grafana-pr-automation bot added the area/panel/timeseries The main time series Graph panel label Jan 23, 2024
@adela-almasan
Merge branch 'main' into leeoniya/barchart-tooltipplugin2
e990f8e 
# Conflicts:
#	public/app/plugins/panel/timeseries/TimeSeriesTooltip.tsx
@adela-almasan
multi mode
1e4cacb
@adela-almasan adela-almasan changed the title [WIP] BarChart: TooltipPlugin2 BarChart: TooltipPlugin2 Feb 2, 2024
@adela-almasan adela-almasan marked this pull request as ready for review February 2, 2024 21:08
@adela-almasan adela-almasan requested a review from a team as a code owner February 2, 2024 21:08
@adela-almasan adela-almasan requested review from Develer and removed request for a team February 2, 2024 21:08
codeincarnate
codeincarnate approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out and looks good. As far as I can tell everything is worked as expected 😄

public/app/plugins/panel/barchart/BarChartPanel.tsx Outdated Show resolved Hide resolved
public/app/plugins/panel/barchart/bars.ts Show resolved Hide resolved
public/app/plugins/panel/barchart/BarChartTooltip.tsx Outdated Show resolved Hide resolved
@aangelisc aangelisc modified the milestones: 10.4.x, 11.0.x Feb 20, 2024
@leeoniya leeoniya merged commit 2c35968 into main Feb 27, 2024
18 checks passed
@leeoniya leeoniya deleted the leeoniya/barchart-tooltipplugin2 branch February 27, 2024 01:18
chalapat pushed a commit to nokia/grafana that referenced this pull request Feb 27, 2024
@leeoniya @adela-almasan @chalapat
BarChart: TooltipPlugin2 (grafana#80920)
bf6be4f 
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
@adela-almasan adela-almasan mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baldm0mma baldm0mma baldm0mma left review comments

@codeincarnate codeincarnate codeincarnate approved these changes

@adela-almasan adela-almasan adela-almasan approved these changes

@Develer Develer Awaiting requested review from Develer Develer is a code owner automatically assigned from grafana/dataviz-squad

@lwandz13 lwandz13 Awaiting requested review from lwandz13

Assignees

@leeoniya leeoniya

Labels
add to changelog area/backend area/frontend area/panel/barchart area/panel/timeseries The main time series Graph panel no-backport Skip backport of PR type/docs
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@leeoniya @codeincarnate @baldm0mma @adela-almasan @aangelisc @fabrizio-grafana