RBAC: Return the underlying error instead of internal server or bad request for managed permission endpoints #80974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IevaVasiljeva
requested review from
undef1nd,
suntala and
idafurjes
and removed request for
a team
IevaVasiljeva
commented
Jan 22, 2024
IevaVasiljeva
changed the title
eleijonmarck
approved these changes
Jan 25, 2024
rwwiv
pushed a commit
that referenced
this pull request
Jan 25, 2024
…equest for managed permission endpoints (#80974) * return not found instead of an internal server error when listing/updating permissions * openapi gen
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
…equest for managed permission endpoints (#80974) * return not found instead of an internal server error when listing/updating permissions * openapi gen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Change the manage permission endpoints to return the underlying errutil error (if any) instead of 500/400 in all cases.
Why do we need this feature?
This makes the returned errors more accurate and informative, and makes it easier for external tooling to work with Grafana's managed permissions. Eg, Terraform processes not found errors differently than internal server errors.
Who is this feature for?
Mostly internal/external devs
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: