Alerting: Add a feature flag to periodically save states #80987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnnyQQQQ
added
area/backend
add to changelog
no-backport
JohnnyQQQQ
requested review from
torkelo,
grafanabot and
a team
as code owners
JohnnyQQQQ
requested review from
rwwiv,
JacobsonMT,
yuri-tceretian,
grobinson-grafana,
papagian,
undef1nd and
suntala
and removed request for
a team
JohnnyQQQQ
changed the title
JohnnyQQQQ
changed the title
JohnnyQQQQ
requested review from
alexweav
and removed request for
torkelo,
a team,
papagian,
undef1nd and
suntala
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grobinson-grafana
approved these changes
Jan 22, 2024
JohnnyQQQQ
force-pushed
the
add-periodic-state-save-ff
branch
from
89f2efc
to
bfa30f5
Compare
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature flag that enables grafana admins to make their grafana instance save the state of alert instances periodically instead of synchronously. This should remove a lot of load for grafana instances that are running a evaluating a lot of alert rules.
The name of the feature flag is
alertingSaveStatePeriodicand the interval for the periodic save can be configured by settingstate_periodic_save_interval, by default it is set to 5 minutes.