Tempo: Support multiple filter expressions for service graph queries #81037
Conversation
domasx2
added
area/frontend
add to changelog
area/datasource/frontend
datasource/Tempo
no-backport
grafana-pr-automation
bot
requested review from
a team and
academo
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
| @@ -67,7 +67,9 @@ export function ServiceGraphSection({ | |||
| ); | |||
| } | |||
|
|
|||
| const filters = queryToFilter(query.serviceMapQuery || ''); | |||
| const filters = queryToFilter( | |||
| (Array.isArray(query.serviceMapQuery) ? query.serviceMapQuery[0] : query.serviceMapQuery) || '' | |||
There was a problem hiding this comment.
Basically to test this right now I am injecting a second query into buildExpr request.targets[0]?.serviceMapQuery but if you are using App O11y I assume there is some way in the UI to add this or programatically because it returns more precise results.
Only frontend Tempo data soruce is upgraded, not adding support for multiple filter expressions to service graph query editor at this time.
Isn't this confusing if the user is getting back results where they can't see the real query that was run?
App o11y has a need to render service graph that contains all nodes matching given filter criteria + their immediate siblings, and have correct request rates for the edges.
Can you give me an example query/how its used from App O11y where you append/inject (not sure if that's what you do or it's visible in the UI in App O11y) the second part that gets the siblings?
There was a problem hiding this comment.
App o11y does not use Tempo service map query editor. We're going for an opinionated experience where queries are created programatically based on context and some high level filters, and are not exposed directly to users.
A specific problem is that customers want to filter app o11y service map by environment (or other attrs), and they want to see nodes that match selected environment + nodes they are directly talking to. So we can't filter this with a single promql filter query, we need to filter serviceMapQuery=['{server_deployment_environment="$env}', '{client_deployment_environment="$env"}'] to get a union of both.
It also enables us to target specifc service and it's sibilings only, by filtering serviceMapQuery=['{server="$name"}', '{client="$name"}']
Related app o11y PR: https://github.com/grafana/app-observability-plugin/pull/767
There was a problem hiding this comment.
Nice, makes sense and thanks for the example 👍
…81037) * support "OR" for service graph queries * make betterer happy * continue appeasing betterer * betterer results
What is this feature?
This PR adds ability pro provide multiple promql filter expressions when making a service map query with Tempo data source. In this case promql OR query is used, result is a union of results for each fitler expression.
target.serviceMapQuerynow accepts array of strings in addition to single string. It is fully backwards compat.Only frontend Tempo data soruce is upgraded, not adding support for multiple filter expressions to service graph query editor at this time.
Why do we need this feature?
App o11y has a need to render service graph that contains all nodes matching given filter criteria + their immediate siblings, and have correct request rates for the edges.
Who is this feature for?
Currently this is needed for app o11y plugin.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: