Grafana/ui: Add deprecation notice to the Form component #81068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
requested review from
Ukochka,
ashharrison90 and
L-M-K-B
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
L-M-K-B
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
LGTM! 🚀
@Clarity-89 can you please add a reference to this PR (e.g. an issue)?
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Grafana/ui: Add deprecation notice to the Form component * Fix notice * Deprecate types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Mark the
Formand other components (and types) that depend on react-hook-form inside grafana/ui as deprecated and suggest alternative usage.Why do we need this feature?
To have a possibility to decouple grafana/ui from react-hook-form in the future.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Please check that: