Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana/ui: Add Space component #81145

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Grafana/ui: Add Space component #81145

merged 9 commits into from
Jan 25, 2024

Conversation

Clarity-89
Copy link
Contributor

What is this feature?

Add Space component to grafana/ui.

Why do we need this feature?

The same component is defined in core Grafana and grafana/experimental. This PR removes that duplication by moving the component to grafana/ui, from where it can be imported inside Grafana as well as plugins.

Who is this feature for?

Grafana and plugin developers.

Which issue(s) does this PR fix?:

Fixes #77185

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Clarity-89 Clarity-89 added this to the 10.4.x milestone Jan 24, 2024
@Clarity-89 Clarity-89 self-assigned this Jan 24, 2024
@Clarity-89 Clarity-89 requested review from a team as code owners January 24, 2024 12:13
@Clarity-89 Clarity-89 requested review from asimpson, bossinc, aangelisc, adamyeats, kevinwcyu, njvrzm, academo, joshhunt and L-M-K-B and removed request for a team January 24, 2024 12:13
@grafana-pr-automation grafana-pr-automation bot requested review from a team and removed request for a team January 24, 2024 12:18
@grafana-pr-automation grafana-pr-automation bot requested review from a team and removed request for a team January 24, 2024 14:21
JoaoSilvaGrafana
JoaoSilvaGrafana reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just leaving some small comments!

packages/grafana-ui/src/components/Layout/Space.mdx Show resolved Hide resolved
packages/grafana-ui/src/components/Layout/Space.story.tsx Show resolved Hide resolved
@grafana-pr-automation grafana-pr-automation bot requested review from a team and removed request for a team January 25, 2024 06:18
@Clarity-89 Clarity-89 merged commit f154b2b into main Jan 25, 2024
18 checks passed
@Clarity-89 Clarity-89 deleted the grafana-ui/add-space branch January 25, 2024 06:59
rwwiv pushed a commit that referenced this pull request Jan 25, 2024
@Clarity-89 @rwwiv
Grafana/ui: Add Space component (#81145)
7d5519b 
* Grafana/ui: Add Space component

* Add responsive styles and prop docs

* Use the Box component

* Docs

* Replace the component from grafana/experimental

* Update story

* Tweak docs

* Adjust docs
bohandley added a commit that referenced this pull request Jan 30, 2024
@bohandley
#81145 Grafana/ui: Add Space component
ccf2f7f
This was referenced Jan 30, 2024
Closed
Closed
Closed
Closed
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@Clarity-89 @Ukochka
Grafana/ui: Add Space component (#81145)
ad5f9cf 
* Grafana/ui: Add Space component

* Add responsive styles and prop docs

* Use the Box component

* Docs

* Replace the component from grafana/experimental

* Update story

* Tweak docs

* Adjust docs
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoSilvaGrafana JoaoSilvaGrafana JoaoSilvaGrafana left review comments

@joshhunt joshhunt joshhunt approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

@njvrzm njvrzm Awaiting requested review from njvrzm njvrzm is a code owner automatically assigned from grafana/aws-datasources

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-frontend

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B is a code owner automatically assigned from grafana/grafana-frontend-platform

@gabor gabor Awaiting requested review from gabor gabor was automatically assigned from grafana/oss-big-tent

@yesoreyeram yesoreyeram Awaiting requested review from yesoreyeram yesoreyeram was automatically assigned from grafana/oss-big-tent

@zoltanbedi zoltanbedi Awaiting requested review from zoltanbedi zoltanbedi was automatically assigned from grafana/oss-big-tent

Assignees

@Clarity-89 Clarity-89

Labels
add to changelog area/frontend datasource/Azure Azure Monitor Datasource datasource/CloudWatch datasource/Loki datasource/Prometheus
Projects
None yet
Milestone
10.4.0
Development

Successfully merging this pull request may close these issues.

grafana/ui: Add Space component
4 participants
@Clarity-89 @joshhunt @JoaoSilvaGrafana @aangelisc