Dashboards: Remove emptyDashboardPage feature flag #81188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergej-Vlasov
requested review from
Clarity-89,
eledobleefe and
mdvictor
and removed request for
a team
|
|
grafana-pr-automation
bot
added
area/backend
area/frontend
area/explore
type/docs
labels
grafana-pr-automation
bot
requested review from
a team and
jackw
and removed request for
a team
joshhunt
reviewed
Jan 24, 2024
| @@ -2431,22 +2431,6 @@ exports[`better eslint`] = { | |||
| [0, 0, 0, "Do not use any type assertions.", "1"], | |||
| [0, 0, 0, "Do not use any type assertions.", "2"] | |||
| ], | |||
| "public/app/features/dashboard/components/AddPanelWidget/AddPanelWidget.test.tsx:5381": [ | |||
ivanortegaalba
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
✅ Feature flag usage removed
✅ Unused code removed
✅ Tests updated
✅ Re-generated docs for FFs without the empty dashboard toggle
Great work @Sergej-Vlasov! Ready to merge!
FYI, the PR is missing a couple of tags:
- Backport tag: If the PR is about a bug fix, that should go into the next patch, we add the proper backport label to the minor where we need to backport these changes. In this case, this is more a cleaning up, so we don't need to backport it.
- Changelog tag: When the change is relevant for a Grafana user, we add the label
add-to-changelogto add the commit message to the Grafana version changelog automatically. In this case, it is something we could add, so we could add it, it won't hurt and if any customer is using the FF, they can remove it from the configuration
Also, it is missing the CLA acceptation from your side 😄
rwwiv
pushed a commit
that referenced
this pull request
Jan 25, 2024
* remove emptyDashboardPage feature toggle from DashNav * remove emptyDashboardPage feature toggle from NewDashboardWithDS * remove emptyDashboardPage feature toggle from DashboardGrid * remove emptyDashboardPage feature toggle from DashboardModel * remove emptyDashboardPage feature toggle from initDashboard * remove unused AddPanelWidged component * remove add-panel type from test * remove emptyDashboardPage feature flag from registry.go
2 tasks
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* remove emptyDashboardPage feature toggle from DashNav * remove emptyDashboardPage feature toggle from NewDashboardWithDS * remove emptyDashboardPage feature toggle from DashboardGrid * remove emptyDashboardPage feature toggle from DashboardModel * remove emptyDashboardPage feature toggle from initDashboard * remove unused AddPanelWidged component * remove add-panel type from test * remove emptyDashboardPage feature flag from registry.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
emptyDashboardPagefeature flag from the codebaseWhich issue(s) does this PR fix?:
Fixes #81055
Special notes for your reviewer:
Please check that: