Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasources: Add concurrency number to the settings #81212

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

itsmylife
Copy link
Contributor

What is this feature?

Currently, only Loki (soon InfluxDB for influxql) is supporting concurrent query execution. Concurrency allows us to execute queries in parallel.

This ensures that the total execution time of multiple queries is only the longest query rather than the sum of all the query times.

Currently, data sources that use concurrency have a hard-coded concurrent query limit. This must be configurable.

Loki concurrency: #74064
InfluxDB concurrency: #81209

Why do we need this feature?

To be able to execute and return responses faster for the requests that have many queries.

Who is this feature for?

For the users that need to run multiple queries in one panel.
⚠️ Concurrency support is on the data source level. Concurrency must be supported by data sources.
Please refer data source documentation for more information

Special notes for your reviewer:
This setting option is not being used anywhere yet. After having this in place Loki and InfluxDB will start using this.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@itsmylife
Copy link
Contributor Author

Should we add this to the changelog?

@itsmylife itsmylife merged commit a3fda08 into main Jan 29, 2024
28 checks passed
@itsmylife itsmylife deleted the ismail/add-concurrency-limit-configuration branch January 29, 2024 10:47
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants