Field: Fix perf regression in getUniqueFieldName() #81323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
added
type/bug
type/performance
no-backport
leeoniya
requested review from
joshhunt,
L-M-K-B and
academo
and removed request for
a team
leeoniya
commented
Jan 26, 2024
| @@ -167,7 +165,7 @@ export function getUniqueFieldName(field: Field, frame?: DataFrame) { | |||
| for (let i = 0; i < frame.fields.length; i++) { | |||
| const otherField = frame.fields[i]; | |||
|
|
|||
| if (isEqual(field, otherField)) { | |||
There was a problem hiding this comment.
root cause of slowdown
leeoniya
commented
Jan 26, 2024
Comment on lines
-44
to
-46
| const fields = data.fields.map((f, idx) => { | ||
| return { ...f, hovered: idx === columnIndex }; | ||
| }); |
There was a problem hiding this comment.
this field copy is why === was failing inside getUniqueFieldName(), and resulting in the 1 suffix, which is the original issue #75511 was attempting to fix.
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
leeoniya
commented
Jan 26, 2024
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
nmarrs
reviewed
Jan 26, 2024
|
this should fix #80039 also? |
1 task
|
If the isEqual approach is in 10.3, then yes, this should be backported |
nmarrs
approved these changes
Jan 26, 2024
nmarrs
reviewed
Jan 26, 2024
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: nmarrs <nathanielmarrs@gmail.com> (cherry picked from commit 0530021)
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: nmarrs <nathanielmarrs@gmail.com> (cherry picked from commit 0530021)
leeoniya
added a commit
that referenced
this pull request
Jan 26, 2024
leeoniya
added a commit
that referenced
this pull request
Jan 26, 2024
* Field: Fix perf regression in getUniqueFieldName() (#81323) Co-authored-by: nmarrs <nathanielmarrs@gmail.com> (cherry picked from commit 0530021) * Chore: Fix some Explore deprecations (#80076) * lint --------- Co-authored-by: Leon Sorokin <leeoniya@gmail.com> Co-authored-by: Giordano Ricci <me@giordanoricci.com>
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/grafana/support-escalations/issues/9134
this fixes a large perf regression in
getFieldDisplayName()introduced in #75511@ryantxu should we backport this?
NOTE: easiest to review each commit separately. the first one is the fix, the second one is an additional optimization for huge-field-count frames.