Transformations: Use the display name of the original y field for the predicted field of the regression analysis transformation. #81332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarkilhed
added
type/bug
add to changelog
area/transformations
no-backport
oscarkilhed
requested review from
codeincarnate and
Develer
and removed request for
a team
7 tasks
baldm0mma
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Have you checked if this denigrates performance at all? I know this specific function (getFieldDisplayName) has created some recent problems for us, most specifically dealt with in this PR @leeoniya has up. 🤔 I don't think this should necessarily stop this change, but just something to keep in mind.
baldm0mma
approved these changes
Jan 26, 2024
nmarrs
approved these changes
Jan 26, 2024
codeincarnate
approved these changes
Jan 29, 2024
oscarkilhed
deleted the
oscark/use-displayname-for-regression-fieldname
branch
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
… predicted field of the regression analysis transformation. (#81332) Fix name of regression transformation field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This sets a better name for the field with the predicted value from the regression analysis transformation
Why do we need this feature?
See #81317
Who is this feature for?
Users of the regression analysis transformation.
Which issue(s) does this PR fix?:
Fixes #81317
Special notes for your reviewer:
Please check that: