Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Move action buttons in the alert list view #81341

Merged
merged 2 commits into from Jan 26, 2024
Merged

Alerting: Move action buttons in the alert list view #81341

merged 2 commits into from Jan 26, 2024

Conversation

soniaAguilarPeiron
Copy link
Member

@soniaAguilarPeiron soniaAguilarPeiron commented Jan 26, 2024 •
edited

What is this feature?

This PR improves the placement of some action buttons we have in the alert list view.
Relocatates each button to its corresponding context.
In particular, this PR moves:

  • the new alert button
  • the new recoding rule button
  • the export all Grafana managed alerts button

This PR also adds a marginBottom in the Mimir/ Cortex / Loki header.

Why do we need this feature?

We need to offer the best UX to our users.

Who is this feature for?

All users.

Special notes for your reviewer:

After the change:

Screenshot 2024-01-26 at 12 17 42

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added this to the 10.4.x milestone Jan 26, 2024
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this Jan 26, 2024
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner January 26, 2024 10:18
@soniaAguilarPeiron soniaAguilarPeiron requested review from gillesdemey and konrad147 and removed request for a team January 26, 2024 10:18
@soniaAguilarPeiron soniaAguilarPeiron force-pushed the alerting/improve-buttons-placement-in-alert-list branch 2 times, most recently from ab820ce to 0db03df Compare January 26, 2024 11:24
@soniaAguilarPeiron soniaAguilarPeiron force-pushed the alerting/improve-buttons-placement-in-alert-list branch from 0db03df to 9bae988 Compare January 26, 2024 13:05
konrad147
konrad147 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@konrad147 konrad147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@soniaAguilarPeiron soniaAguilarPeiron merged commit f042ca5 into main Jan 26, 2024
14 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the alerting/improve-buttons-placement-in-alert-list branch January 26, 2024 13:56
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@soniaAguilarPeiron @Ukochka
Alerting: Move action buttons in the alert list view (#81341)
767912e 
Move action buttons in the alert list view
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konrad147 konrad147 konrad147 approved these changes

@gillesdemey gillesdemey Awaiting requested review from gillesdemey gillesdemey is a code owner automatically assigned from grafana/alerting-frontend

Assignees

@soniaAguilarPeiron soniaAguilarPeiron

Labels
add to changelog area/alerting Grafana Alerting area/backend/api area/frontend no-backport Skip backport of PR
Projects
Alerting
Archived in project
Milestone
10.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soniaAguilarPeiron @konrad147 @aangelisc