-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tempo: Add query ref in the query editor #81343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabrizio-grafana
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fabrizio-grafana
approved these changes
Jan 29, 2024
Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>
fabrizio-grafana
approved these changes
Jan 29, 2024
@joey-grafana I don't think this is best way to fix this.
|
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Add query ref * Fix lint * Add comment * Update public/app/plugins/datasource/tempo/traceql/QueryEditor.tsx Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com> --------- Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/datasource/frontend
area/frontend
datasource/Tempo
no-backport
Skip backport of PR
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds a query ref in the Tempo query editor.
Why do we need this feature?
We pass in the query to the Monaco editor but do not also pass updates to the query. So, when the query changes and then the text in the Monaco field (i.e. the TraceQL field) is updated, Monaco will update the Tempo query with the new TraceQL query but unfortunately uses the original Tempo query (without any updates from the user) it was given in the Query Editor
onEditorChange
and so any changes will not be reflected.In this PR we add a ref so that Monaco always has the latest values for query.
Who is this feature for?
Tempo users
Which issue(s) does this PR fix?:
Fixes #81192
Fixes #81193
Special notes for your reviewer:
Please check that: